Fix #2513: Update logging effect in automation #3437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Print the executed commands and exit code when a test is failed. 2. Print the failed commands' output. 3. Hide msrest, vcr, or any other logger.
Codecov Report
@@ Coverage Diff @@
## master #3437 +/- ##
==========================================
+ Coverage 70.76% 70.78% +0.01%
==========================================
Files 394 394
Lines 25586 25582 -4
Branches 3900 3898 -2
==========================================
+ Hits 18106 18107 +1
+ Misses 6333 6330 -3
+ Partials 1147 1145 -2
Continue to review full report at Codecov.
|
tjprescott
reviewed
May 24, 2017
|
|
||
|
|
||
| class IntegrationTestBase(unittest.TestCase): | ||
| def __init__(self, method_name): | ||
| super(IntegrationTestBase, self).__init__(method_name) | ||
| self.diagnose = os.environ.get(ENV_TEST_DIAGNOSE, None) == 'True' | ||
|
|
||
| def cmd(self, command, checks=None, expect_failure=False): | ||
| if self.diagnose: |
There was a problem hiding this comment.
Is this being removed? I use this extensively during local troubleshooting. Or is this now accomplished another way?
There was a problem hiding this comment.
The command will print in logging whenever the test fails. You don't need to set diagnostics anymore.
There was a problem hiding this comment.
Okay, let's give it a shot :)
tjprescott
approved these changes
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Command Guidelines
(see Authoring Command Modules)